update(theme): adjust base16_transparent and dark_high_contrast #5105
Conversation
| "diagnostic.debug" ={ fg ="gray", modifiers = ["underlined"] } | ||
| "diagnostic.warning" = { fg = "yellow", modifiers = ["underlined"] } | ||
| "diagnostic.error" = { fg ="light-red", modifiers = ["underlined"] } | ||
| "diagnostic.info" = { underline = { color = "light-blue", style = "dot" } } |
There was a problem hiding this comment.
I think the documentation is currently incorrect about this underline style, it should be dotted:
helix/helix-view/src/graphics.rs
Line 323 in f323ffa
There was a problem hiding this comment.
Yeah I think I mixed that up 😅 I think the documentation was what I originally planning. We use curl and line so using the passive dotted and dashed seemed inconsistent. Perhaps this should be changed to dashes and dots in both documentation and implementation?
There was a problem hiding this comment.
I think they're ok as passive - it makes sense to me as "dotted line" or "dashed line". When in doubt I would say we should follow whatever kitty says they are but it looks like then we would need to change to "curly" too for consistency: https://sw.kovidgoyal.net/kitty/underlines/
I think that just updating the documentation to say "dotted" would be the best choice to minimize breaking changes
pascalkuthe
added
A-theme
|
Also added dark_high_contrast
|
GreasySlug
changed the title
the-mikedavis
changed the title
underlineinstead ofmodifier = ["underlined"]